-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Nested @Embedded #367
Support for Nested @Embedded #367
Conversation
Hi @isaac-mercieca, thanks for the PR! Could you, please, add unit tests to cover the fix? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
============================================
- Coverage 76.10% 76.01% -0.10%
- Complexity 1133 1136 +3
============================================
Files 75 75
Lines 5081 5103 +22
Branches 732 732
============================================
+ Hits 3867 3879 +12
- Misses 890 899 +9
- Partials 324 325 +1 ☔ View full report in Codecov by Sentry. |
…r a nested embeddable
@igdianov I have added a test under |
@isaac-mercieca The schema test looks good. Please, include an integration test with the query using embedded attributes in the where criteria and selection. This will bring the required test coverage threshold to pass codecov checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to have integration test to cover query execution
Fixed bug when generating the GraphQL schema for an Embeddable as the system was not taking into consideration having nested representations annotated with
Embedded
. By enhancinggetEmbeddableType
underGraphQLJpaSchemaBuilder
so that generation is done in a recursive manner the system now supports an infinite amount of nestable classes annotated withEmbedded
.Resolved #336