Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create receiver 401 with multiple vus #3300

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: create receiver 401 with multiple vus #3300

merged 1 commit into from
Feb 18, 2025

Conversation

BlairCurrey
Copy link
Contributor

@BlairCurrey BlairCurrey commented Feb 13, 2025 •
edited
Loading

Changes proposed in this pull request

  • Fixes bug in performance tests where requests 401 because they are identified as duplicates (happen within same ms). Only happens with multiples vus. Adds nonce value to differentiate requests.

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@BlairCurrey
fix: create receiver 401 with multiple vus
a0a56eb 
- identified as a duplicate request by backend
adds nonce to differentiate
@BlairCurrey BlairCurrey requested a review from mkurapov February 13, 2025 17:21
@github-actions github-actions bot added the type: tests Testing related label Feb 13, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 13, 2025 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit a0a56eb
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/67ae2a0f7752a800089947e2

@BlairCurrey BlairCurrey merged commit 641d23b into main Feb 18, 2025
33 of 43 checks passed
@BlairCurrey BlairCurrey deleted the bc/fix-perf-bug branch February 18, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

Assignees
No one assigned
Labels
type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlairCurrey @mkurapov