Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Proper API specs/docs using Swagger #323

Closed
eshaan7 opened this issue Jan 20, 2021 · 13 comments · Fixed by #369
Closed

[docs] Proper API specs/docs using Swagger #323

eshaan7 opened this issue Jan 20, 2021 · 13 comments · Fixed by #369
Labels
documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code
Milestone

Comments

@eshaan7
Copy link
Member

eshaan7 commented Jan 20, 2021

  • Writing proper documentation for the API endpoint functions (api_app/api.py)

Need to use proper syntax as given here.
Originally posted by @eshaan7 in #344 (comment)

@eshaan7 eshaan7 added the documentation Improvements or additions to documentation label Jan 20, 2021
@spiderxm
Copy link

assign me this issue

@purhan
Copy link

purhan commented Feb 24, 2021

It's been a while since this was assigned to someone. I'd like to work on this if it's open for contribution!

@mlodic mlodic assigned purhan and unassigned spiderxm Feb 24, 2021
@mlodic
Copy link
Member

mlodic commented Feb 24, 2021

hey @purhan thank you for your interest in the project! You have been assigned

@purhan purhan mentioned this issue Feb 25, 2021
12 tasks
@purhan
Copy link

purhan commented Feb 25, 2021

@mlodic Thanks for assigning! I have created a PR. Review will be appreciated.

@eshaan7 eshaan7 linked a pull request Feb 26, 2021 that will close this issue
@purhan purhan removed their assignment Feb 26, 2021
@CITIZENDOT
Copy link
Contributor

CITIZENDOT commented Mar 11, 2021

Also I think we should rewrite the docstrings of the APIs because swagger cannot parse that data correctly.

Yes, it's our mistake for not following a proper syntax while writing doc strings.

Need to use proper syntax as given here.

descriptions for Operations, Parameters and Schemas are picked up from docstrings and help_text attributes in the same manner as the default DRF SchemaGenerator

Originally posted by @eshaan7 in #344 (comment)

So, Before diving into swagger, We have to fix doc strings, Right? Let me do that then.

@eshaan7 eshaan7 linked a pull request Mar 31, 2021 that will close this issue
11 tasks
@mlodic
Copy link
Member

mlodic commented Apr 15, 2021

solved with #417

@mlodic mlodic closed this as completed Apr 15, 2021
@eshaan7 eshaan7 reopened this Apr 30, 2021
@eshaan7
Copy link
Member Author

eshaan7 commented Apr 30, 2021

The GH action automation part of this issue still needs to be done. (could use https://github.com/NiklasRosenstein/readthedocs-custom-steps/)

@uzaxirr
Copy link
Contributor

uzaxirr commented Dec 9, 2021

Hey, can anyone clarify what part of this issue is solved and what needs to be implemented more?

@fear-the-reaper
Copy link
Contributor

Hello! Is this issue still open? If so can you clarify what needs to be done? Thanks!

@mlodic
Copy link
Member

mlodic commented Feb 22, 2022

Honestly I did not understand what @eshaan7 meant by that. I guess this could be closed

@eshaan7
Copy link
Member Author

eshaan7 commented Feb 22, 2022

The schema.yml file is not automatically updated and we need a GitHub action to manage this. (As you can see even right now, the schema.yml file says the version is 3.1.0 even though we are on 3.3.0)

This workflow could be made part of the existing sphinx_build_on_release.yml file.

The schema.yml file is generated using the drf-spectacular django app using the following management command:

$ python manage.py spectacular --file docs/source/schema.yml

@eshaan7 eshaan7 added beginner-friendly github_actions Pull requests that update Github_actions code labels Feb 22, 2022
@mlodic mlodic added this to the v4.0 milestone Apr 11, 2022
@mlodic
Copy link
Member

mlodic commented Jul 14, 2022

Yeah plus I honestly don't like the result we had with Redoc and would preferably move to Swagger.

@mlodic mlodic pinned this issue Sep 4, 2023
@mlodic mlodic unpinned this issue Dec 29, 2023
@mlodic
Copy link
Member

mlodic commented Dec 29, 2023

superseded by #2043

@mlodic mlodic closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code
Projects
None yet
7 participants