-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Proper API specs/docs using Swagger #323
Comments
assign me this issue |
It's been a while since this was assigned to someone. I'd like to work on this if it's open for contribution! |
hey @purhan thank you for your interest in the project! You have been assigned |
@mlodic Thanks for assigning! I have created a PR. Review will be appreciated. |
Yes, it's our mistake for not following a proper syntax while writing doc strings. Need to use proper syntax as given here.
Originally posted by @eshaan7 in #344 (comment) So, Before diving into swagger, We have to fix doc strings, Right? Let me do that then. |
solved with #417 |
The GH action automation part of this issue still needs to be done. (could use https://github.com/NiklasRosenstein/readthedocs-custom-steps/) |
Hey, can anyone clarify what part of this issue is solved and what needs to be implemented more? |
Hello! Is this issue still open? If so can you clarify what needs to be done? Thanks! |
Honestly I did not understand what @eshaan7 meant by that. I guess this could be closed |
The schema.yml file is not automatically updated and we need a GitHub action to manage this. (As you can see even right now, the schema.yml file says the version is 3.1.0 even though we are on 3.3.0) This workflow could be made part of the existing sphinx_build_on_release.yml file. The schema.yml file is generated using the drf-spectacular django app using the following management command: $ python manage.py spectacular --file docs/source/schema.yml |
Yeah plus I honestly don't like the result we had with Redoc and would preferably move to Swagger. |
superseded by #2043 |
sphinx-redoc
extension to generate redoc along with rest of the docs. Then link both docs together with something like this. There should be a GH workflow setup for this.The text was updated successfully, but these errors were encountered: