Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes only to requirements.txt don't get auto-merged with 2 approvals #467

Closed
bbrowning opened this issue Jan 9, 2025 · 1 comment · Fixed by #468
Closed

Changes only to requirements.txt don't get auto-merged with 2 approvals #467

bbrowning opened this issue Jan 9, 2025 · 1 comment · Fixed by #468
Assignees
@nathan-weinberg
Labels
bug Something isn't working CI/CD Affects CI/CD configuration

Comments

@bbrowning
Copy link
Contributor

In #465 we discovered that a change only to requirements.txt does not get automatically merged by mergify after two approvals. We need to adjust the mergify config to handle this case.
@bbrowning bbrowning mentioned this issue Jan 9, 2025
Merged
@nathan-weinberg
Copy link
Member

I can take a look at this

@nathan-weinberg nathan-weinberg self-assigned this Jan 9, 2025
@nathan-weinberg nathan-weinberg added bug Something isn't working CI/CD Affects CI/CD configuration labels Jan 9, 2025
@nathan-weinberg nathan-weinberg mentioned this issue Jan 9, 2025
Merged
@mergify mergify bot closed this as completed in #468 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathan-weinberg nathan-weinberg

Labels
bug Something isn't working CI/CD Affects CI/CD configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: typo in mergify configuration nathan-weinberg/sdg
2 participants
@bbrowning @nathan-weinberg