Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish syncing LLMMessagesBlock from research code #414

Open
Tracked by #373
bbrowning opened this issue Nov 27, 2024 · 0 comments · May be fixed by #461
Open
Tracked by #373

Finish syncing LLMMessagesBlock from research code #414

bbrowning opened this issue Nov 27, 2024 · 0 comments · May be fixed by #461
Assignees
@bbrowning

Comments

@bbrowning
Copy link
Contributor

#409 Only brings in a stub of LLMMessagesBlock with the actual functionality commented out. We need to uncomment, adjust to fit our upstream conventions and params, and add tests for this block's intended functionality.
This was referenced Nov 27, 2024
Merged
Open
@bbrowning bbrowning self-assigned this Jan 6, 2025
bbrowning added a commit to bbrowning/instructlab-sdg that referenced this issue Jan 6, 2025
@bbrowning
Implement LLMMessagesBlock
8576050 
This was just a commented out stub before, ported over from the
research prototypes. This uncomments it, ports things to work within
the current structure of InstructLab, and adds a few tests to verify
the logic within the block.

Fixes instructlab#414

Signed-off-by: Ben Browning <[email protected]>
@bbrowning bbrowning linked a pull request Jan 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbrowning bbrowning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement LLMMessagesBlock bbrowning/instructlab-sdg
1 participant
@bbrowning