Should min_length_time_axis default to sample_sequence_length?

[mickvangelderen]

As far as I understand, in order to sample a trajectory of length sample_sequence_length, the time axis dimensions, defined by min_length_time_axis, must be at least as long as sample_sequence_length.

I think the API would be improved if min_length_time_axis and min_length can default to sample_sequence_length and add_batch_size * sample_sequence_length respectively. Currently the tests raise warnings triggered by flashbax itself about the min_length or min_length_time_axis being smaller than the required minimum.

Perhaps the arguments can be removed entirely, but keeping them allows users to require the buffer to have more data before it can be sampled, which is probably a legitimate use-case.

Note, I am only just getting familiar with this library so I may have misunderstood something.