-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elements: urls.value should not be validated as URI #280
Comments
Thing is, it makes a lot of sense to validate URLs as URIs, while it makes less sense to store there what are essentially external system identifiers. So my proposal is to relax temporarily this field to unblock inspirehep/inspire-next#2992 and inspirehep/inspire-next#2904 ASAP, and then restrict again when we have another place in the schema to put this information. |
Not sure I understand. The content of those fields are not URLs but external system identifiers, so they should be moved there. Note that this is already foreseen in commit e5a1ff4 (part of #182), that adds twitter and linkedin to the allowed author |
One of the authors that fails migration is part of our demo set of records, which means we can't bump the schemas (which is happening in commit inspirehep/inspire-next@2afcbb0 of inspirehep/inspire-next#2992), which is blocking the manual merger from being merged. |
can't you patch the demo records then? It seems cleaner to me to do a temporary patch at the point of failure rather than here. |
👍 Will do like you suggest, and thanks for the weekend answer... |
We currently have
inspire-schemas/inspire_schemas/records/elements/url.yml
Lines 10 to 14 in afcc205
which would become
but
@particleist
isn't a URI.The text was updated successfully, but these errors were encountered: