Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform documentation and behavior for na_str - Can I add a vector? #251

Open
Melkiades opened this issue Jan 23, 2024 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request sme Tracks changes for the sme board

Comments

@Melkiades
Copy link
Contributor

@Melkiades on second thought, I think we should make a separate PR to tackle this issue - we have to also consider the fact that users can supply multiple na_str values for multi-value formats (e.g. na_str = c("lo", "hi") for "xx.xx - xx.xx"), which would complicate enabling vector input.

I see! Have you made it already? I think we need to understand how it is exactly applied and uniform that. In other words, we have to see exactly what providing a vector entails. From a user perspective, you would do 3 things: (1) one for all na_str (current default). (2) 2+ for specific formats (how do we select them externally? I do not remember, is na_str working as formats, that you can specify different values with named vectors?) (3) assign them all in order (if less, cycle)

Originally posted by @edelarua @Melkiades in #250 (comment)

@Melkiades Melkiades added bug Something isn't working enhancement New feature or request sme Tracks changes for the sme board labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request sme Tracks changes for the sme board
Projects
None yet
Development

No branches or pull requests

1 participant