From 14d296a3c5934147903975fe1dea9426bd6f04db Mon Sep 17 00:00:00 2001 From: krakhit <61501745+krakhit@users.noreply.github.com> Date: Sun, 3 Nov 2024 15:21:45 +0200 Subject: [PATCH] minor updates --- docs/docs/icicle/primitives/hash.md | 2 +- icicle/include/icicle/hash/poseidon.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/docs/icicle/primitives/hash.md b/docs/docs/icicle/primitives/hash.md index ac7428234..cd64bae8e 100644 --- a/docs/docs/icicle/primitives/hash.md +++ b/docs/docs/icicle/primitives/hash.md @@ -136,7 +136,7 @@ eIcicleErr err = keccak256.hash(input.data(), input.size() / config.batch, confi ### 4. Posidon sponge function -Currently the poseidon sponge function isn't implemented. +Currently the poseidon sponge function (Sec 2.1 of https://eprint.iacr.org/2019/458.pdf ) isn't implemented. ### Supported Bindings diff --git a/icicle/include/icicle/hash/poseidon.h b/icicle/include/icicle/hash/poseidon.h index 2f4b897cb..fcb374905 100644 --- a/icicle/include/icicle/hash/poseidon.h +++ b/icicle/include/icicle/hash/poseidon.h @@ -10,6 +10,7 @@ namespace icicle { * contexts and use cases. The width parameter (`t`) determines the number of elements in the state, * influencing the security level and output structure of the hash. The optional `domain_tag` pointer parameter * enables domain separation, allowing isolation of hash outputs across different contexts or applications. + * (See here for a detailed explanation: https://hackmd.io/@7dpNYqjKQGeYC7wMlPxHtQ/ByIbpfX9c#SAFE-Sponge-API-for-Field-Elements-–-A-Toolbox-for-ZK-Hash-Applications) * * @param S Represents the type of the field element used by the hash (e.g., a field element class). *