-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit full screen mode in Yosemite #180
Comments
I've hit the same issue too. Any ideas about a fix or a workaround? |
I don't. I only use INAppStoreWindow for the ability to change title bar colour, so I'm probably going to abandon it and move to a textured window with custom content view. |
I was able to fix this issue and get the buttons to show for me by disabling these 3 lines in Yosemite: INAppStoreWindow/INAppStoreWindow/INAppStoreWindow.m Lines 1161 to 1163 in 45c5f6b
As far as I can tell, the issue is caused by INAppStoreWindow trying to change the frame of the buttons (even if you didn't customise anything related to the window buttons). Disabling the change of frame of Unfortunately I don't have the time to look into this further and fix it properly (i.e. find a way to get the buttons to actually change frame reliably so they can be customised), so I can't submit a pull request. |
I can confirm that your workaround works on Yosemite. I've put our version of the workaround here: This needs some further work still -- the traffic light buttons don't center again after coming back from fullscreen with this workaround in place (they do center again after the window is resized after that). |
Maybe this could be the answer: #192 |
@indragiek & @jakepetroules this seems to affect a lot of people, do you guys think we can get this fixed/merged? |
I have the same issue. |
In Yosemite click the green traffic light can enter and exit full screen mode. INAppStoreWindow didn't show traffic light under full screen mode, users can't exit like other apps by clicking the green traffic light.
The text was updated successfully, but these errors were encountered: