-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base64 fallback on previous OS X versions #161
Comments
So, the method I used is only available in the 10.9 SDK but is available in the runtime from 10.6. And is deprecated. Suggested solution: duplicate the forward declaration. Simple but effective. |
@jakepetroules Is that documented anywhere? |
Yes, in the comments next to the method in the corresponding system header file. Also, in the signature of the NS_AVAILABLE macro annotating the method. |
👍 I'll push that change tomorrow. |
Please release a v1.5 on CocoaPods soon too! :) |
After closing this and figuring out whats up with #162 that sounds like a good time to tag a new release. |
Just realized that
-[NSData initWithBase64Encoding]
is only available on OS X 10.9. There are many apps that still require OS X 10.7+ compatibility, so there needs to be a fallback of some kind. One way is to include a base64 decoder inINAppStoreWindow.m
from one of the many open source implementations out there. Another option is to fall back to using the old drawing method when running on anything lower than 10.9. I'm leaning towards the former./cc @jakepetroules
The text was updated successfully, but these errors were encountered: