From 72c4d31e7f53dbb3f7b5b0093240795b77869be2 Mon Sep 17 00:00:00 2001 From: Patrick Schuenke Date: Mon, 3 Feb 2025 15:07:13 +0100 Subject: [PATCH] revert error, remove ne workflow step again --- .github/workflows/push_pr.yml | 17 ----------------- tests/test_block.py | 1 - 2 files changed, 18 deletions(-) diff --git a/.github/workflows/push_pr.yml b/.github/workflows/push_pr.yml index bcb1d3b6..ba8012e7 100644 --- a/.github/workflows/push_pr.yml +++ b/.github/workflows/push_pr.yml @@ -63,23 +63,6 @@ jobs: pytest-coverage-path: pytest-coverage.txt junitxml-path: pytest.xml - - name: Post Failure Comment if Coverage Comment failed - # if there is no data the comment action does not fail but has an empty output - if: steps.coverageComment.outputs.coverageHtml == '' - uses: edumserrano/find-create-or-update-comment@v3 - with: - issue-number: ${{ github.event.workflow_run.event.pull_request.number }} - # see https://github.com/MishaKav/pytest-coverage-comment/blob/81882822c5b22af01f91bd3eacb1cefb6ad73dc2/src/index.js#L97 - # for the generation of the unique id for comment - # in this particular case, there is no additional watermarkUniqueId - body-includes: "" - comment-author: "github-actions[bot]" - body: | - - ### :x: PyTest Coverage Report was not found - Check the PyTest Workflow - edit-mode: replace - concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} diff --git a/tests/test_block.py b/tests/test_block.py index c8659c91..98865feb 100644 --- a/tests/test_block.py +++ b/tests/test_block.py @@ -20,7 +20,6 @@ def test_gradient_continuity1(): seq.add_block(gx_trap) seq.add_block(gx_extended) seq.add_block(gx_trap) - assert False def test_gradient_continuity2():