Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor opener intercepts #24

Open
hinerm opened this issue Jun 10, 2014 · 0 comments
Open

Refactor opener intercepts #24

hinerm opened this issue Jun 10, 2014 · 0 comments

Comments

@hinerm
Copy link
Member

hinerm commented Jun 10, 2014

Right now we have a lot of instanceof checks and we're really using the DefaultLegacyOpener in two different ways.

If we come from an open path where we are given a String source, then if the LegacyOpener fails we want to continue to IJ1 with our given source.

If we come from an open path where we weren't given a String source and one is chosen during IJ2 execution, which then fails, we want to continue to IJ1 with the source selected in IJ2.

In the second case we ALWAYS want to return the path from IJ2. In the first case, we don't care about the String and it's effectively the same as a null value.

@ctrueden ctrueden added this to the unscheduled milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants