Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node 20 #17

Closed
wants to merge 3 commits into from
Closed

Update Node 20 #17

wants to merge 3 commits into from

Conversation

bradyclifford
Copy link
Contributor

@bradyclifford bradyclifford commented Apr 3, 2024

Summary of PR changes

Update package dependencies and node to latest LTS supported by GitHub actions.

Tested in run: https://github.com/im-enrollment/ifp-connector-infrastructure/actions/runs/8546643299/job/23417428431

image

PR Requirements

  • For major, minor, or breaking changes, at least one of the commit messages contains the appropriate +semver: keywords.
    • See the Incrementing the Version section of the repository's README.md for more details.
  • The action code does not contain sensitive information.

NOTE: If the repo's workflow could not automatically update the README.md, it should be updated manually with the next version. For javascript actions, if the repo's workflow could not automatically recompile the action it should also be updated manually as part of the PR.

+semver:minor
@bradyclifford bradyclifford self-assigned this Apr 3, 2024
@bradyclifford bradyclifford requested a review from a team as a code owner April 3, 2024 22:46
Copy link

github-actions bot commented Apr 3, 2024

Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.

  • Please update the action's version in the Usage Examples section of README.md. Each instance of this action should be updated to:
    uses: im-open/[email protected]
  • Please ensure the action has been recompiled by running the following command from the root of the repository:
    npm run build

Copy link

github-actions bot commented Apr 3, 2024

Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.

  • Please ensure the action has been recompiled by running the following command from the root of the repository:
    npm run build

@bradyclifford
Copy link
Contributor Author

bradyclifford commented Apr 12, 2024

Can you run a build locally using Node 20 and push it up into this PR @DougDyreng? I have node 21 on my machine and the build in this repo doesn't like that.

Copy link

Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.

  • Please update the action's version in the Usage Examples section of README.md. Each instance of this action should be updated to:
    uses: im-open/[email protected]
  • Please ensure the action has been recompiled by running the following command from the root of the repository:
    npm run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants