Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete failed test result in GH comment #16

Open
erikujczo opened this issue Aug 24, 2023 · 1 comment
Open

Incomplete failed test result in GH comment #16

erikujczo opened this issue Aug 24, 2023 · 1 comment

Comments

@erikujczo
Copy link

erikujczo commented Aug 24, 2023

Issue description

I've encountered an issue with incomplete reports of failed tests in GitHub comments.

Problematic failed test report:

// getFailedTestMarkup -> failedTest.failureMessages
[
  'Error: expect(received).not.toBeInstanceOf(expected)\n' +
    '\n' +
    'Expected constructor: not bound ApolloError\n' +
    'Received constructor:     ApolloError extends … extends bound ApolloError\n' +
    '\n' +
    '    at Object.<anonymous>\n' +
    '    at runMicrotasks (<anonymous>)\n' +
    '    at processTicksAndRejections (node:internal/process/task_queues:96:5)'
]

The problem arises from the second new line that includes four or more white space spaces on the following line.

    '\n' +
    '    at Object.<anonymous>\n' +

GitHub comments disregard everything after this combination of characters, which results in the failure to display other failed test results.

@danielle-casella-adams
Copy link
Contributor

The recent v2.2.0 generated from #21 may address this issue for you. The code was cleaned up so it generated valid markdown. Please let us know if this is still an issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants