Publish/Subscribe pattern #3140
Open
+927
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Any idea why sonarcloud does not seem to analyze the code? |
iluwatar
requested changes
Jan 6, 2025
Comment on lines
+11
to
+13
| /** | ||
| * Main application demonstrating different aspects of JMS publish-subscribe pattern. | ||
| */ |
There was a problem hiding this comment.
Describe the pattern and explain how this example implements it
| demonstrateSharedSubscriptions(); | ||
| } catch (Exception e) { | ||
| System.err.println("Error in publish-subscribe demo: " + e.getMessage()); | ||
| e.printStackTrace(); |
| } finally { | ||
| cleanup(null); | ||
| } | ||
| JmsUtil.closeConnection(); |
There was a problem hiding this comment.
Should this be inside the finally block?
|
|
||
| try { | ||
| // Create basic subscribers | ||
| subscribers.add(new TopicSubscriber("BasicSub1", "NEWS", SubscriberType.NONDURABLE, null)); |
There was a problem hiding this comment.
Use constants for strings like this
Comment on lines
+17
to
+23
| public String getContent() { | ||
| return content; | ||
| } | ||
|
|
||
| public String getTopic() { | ||
| return topic; | ||
| } |
There was a problem hiding this comment.
Use Lombok to get rid of boilerplate
Comment on lines
+1
to
+17
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <Configuration status="INFO"> | ||
| <Appenders> | ||
| <Console name="Console" target="SYSTEM_OUT"> | ||
| <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/> | ||
| </Console> | ||
| </Appenders> | ||
| <Loggers> | ||
| <Root level="info"> | ||
| <AppenderRef ref="Console"/> | ||
| </Root> | ||
| <!-- Reduce ActiveMQ logging --> | ||
| <Logger name="org.apache.activemq" level="warn" additivity="false"> | ||
| <AppenderRef ref="Console"/> | ||
| </Logger> | ||
| </Loggers> | ||
| </Configuration> |
There was a problem hiding this comment.
You can use Lombok's logger instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the Publish/Subscribe design pattern using JMS
Close #2898