Skip to content
This repository has been archived by the owner on Apr 20, 2020. It is now read-only.

calling setValue on rtype List does not work #67

Open
akreshuk opened this issue Oct 25, 2012 · 3 comments
Open

calling setValue on rtype List does not work #67

akreshuk opened this issue Oct 25, 2012 · 3 comments
Milestone

Comments

@akreshuk
Copy link
Member

If you call setValue on a slot, it then calls setDirty(slice(None)), which fails, if the slot rtype is a list, because slice object is not iterable. Maybe we need special handling for this case? Like some "everything" property for all types of slots?

@stuarteberg
Copy link
Member

The SubRegion rtype defaults to "everything" if no arguments are given to its constructor (other than the slot). Should this be a rule for all rtypes? By the way, we need to keep Issue #57 in mind when solving this.

To eliminate your crash, you could just change line 896 of graph.py to say: self.setDirty(), but that may not be what you want, since the List rtype doesn't default to "everything". It defaults to "nothing", so calling setValue won't mark your slot as dirty.

@akreshuk
Copy link
Member Author

This was fixed by back then a bad hack at line 70 of rtype.py. We should find a better way now that we are really using rtype Lists.

@ghost ghost assigned cstraehl Apr 2, 2013
@cstraehl
Copy link
Member

cstraehl commented Apr 9, 2013

hmm. This rtype list does not make muche sense anyway, especially with a slot type of Opaque.

we should get rid of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants