Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty implementations should be a one liner #11

Open
mokagio opened this issue Feb 10, 2017 · 2 comments
Open

Empty implementations should be a one liner #11

mokagio opened this issue Feb 10, 2017 · 2 comments

Comments

@mokagio
Copy link
Contributor

mokagio commented Feb 10, 2017

I'd like to suggest to add this guideline:

Preferred

struct Empty { }

Not Preferred

struct Empty {
}

struct Empty {
  // nothing to see here
}

struct Empty {

}
@nhisyam
Copy link

nhisyam commented Mar 9, 2017

I am 50-50 on this. Would prefer to let it be up to the author.

@martinpilch
Copy link

One liner looks better to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants