Skip to content

Commit

Permalink
Don't emit errors when there are no listeners for the error event as …
Browse files Browse the repository at this point in the history
…it results in unhandled errors
  • Loading branch information
NikitaKurpas committed Jan 7, 2019
1 parent b0c7cd5 commit b39cddc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@iflix/json-rules-engine",
"version": "4.0.0",
"version": "4.0.1",
"description": "Rules Engine expressed in simple json",
"main": "dist/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions src/engine.js
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class Engine extends EventEmitter {
this.emit('failure', rule.event, almanac, ruleResult)
}
}).catch((error) => {
this.emit('error', error)
this.listenerCount('error') > 0 && this.emit('error', error)
throw error
})
}))
Expand All @@ -224,7 +224,7 @@ class Engine extends EventEmitter {
debug(`engine::run ruleResult:${ruleResult.result}`)
return ruleResult
}).catch((error) => {
this.emit('error', error)
this.listenerCount('error') > 0 && this.emit('error', error)
throw error
})
}
Expand Down
2 changes: 1 addition & 1 deletion src/rule.js
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ class Rule extends EventEmitter {
error.rule = {
name: this.name
}
this.emit('error', error)
this.listenerCount('error') > 0 && this.emit('error', error)
throw error
}

Expand Down

0 comments on commit b39cddc

Please sign in to comment.