Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISA extension: BPF_CALL | BPF_X #82

Open
dthaler opened this issue Jan 28, 2024 · 4 comments
Open

ISA extension: BPF_CALL | BPF_X #82

dthaler opened this issue Jan 28, 2024 · 4 comments
Labels
Extension Leave for a separate extension document

Comments

@dthaler
Copy link
Collaborator

dthaler commented Jan 28, 2024

clang has generated this invalid instruction with -O0 and -O1 for ages.
Allowing its use with something other than the meaning clang gives it might be problematic, though clang's meaning is intuitive.
Should the IANA registry have an entry for it or not?

@dthaler
Copy link
Collaborator Author

dthaler commented Jan 30, 2024

@dthaler
Copy link
Collaborator Author

dthaler commented Feb 1, 2024

Jose Marchesi wrote:

GCC also generates BPF_CALL|BPF_X also named callx, but only if the
experimental -mxbpf option is passed to the compiler.

I recommend this particular encoding to be specifically reserved for a
future `call REG' for when/if a time comes when the BPF verifier
supports some form of indirect calls.

Alexei wrote:

+1.
Same thinking from llvm pov.
CALL|X is what we will use when the kernel supports indirect calls.
I think it means we need to add a 'reserved' category to the spec.

@dthaler
Copy link
Collaborator Author

dthaler commented Feb 7, 2024

This also now makes me think we should probably rename the "legacy" conformance group to "packet" for similar reasons. It's the status (Historical) of the group rather than the name that actually makes it legacy.

@dthaler dthaler changed the title ISA: should BPF_CALL | BPF_X be reserved? ISA: BPF_CALL | BPF_X Feb 7, 2024
@dthaler
Copy link
Collaborator Author

dthaler commented Feb 8, 2024

@dthaler dthaler added the have proposed text Proposed patch posted label Feb 8, 2024
@dthaler dthaler removed the have proposed text Proposed patch posted label Mar 1, 2024
@dthaler dthaler changed the title ISA: BPF_CALL | BPF_X ISA extension: BPF_CALL | BPF_X Mar 1, 2024
@dthaler dthaler added the Extension Leave for a separate extension document label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extension Leave for a separate extension document
Projects
None yet
Development

No branches or pull requests

1 participant