Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISA: Gunter Van de Velde comments #160

Open
dthaler opened this issue Jun 20, 2024 · 3 comments
Open

ISA: Gunter Van de Velde comments #160

dthaler opened this issue Jun 20, 2024 · 3 comments
Labels
fixed in editors copy Fixed in github repo ISA Affects ISA draft

Comments

@dthaler
Copy link
Collaborator

dthaler commented Jun 20, 2024

Gunter Van de Velde, RTG AD, comments for draft-ietf-bpf-isa-03

Please find https://www.ietf.org/blog/handling-iesg-ballot-positions/ documenting the handling of ballots.

This is rather far away from my expertise area and i trust my fellow ADs more skilled in this area to have a more thorough technology review.
From a generalist perspective the text reads good and the draft is well structured. I see no objections for this work to proceed

#COMMENTS
#========

12 eBPF (which is no longer an acronym for anything), also commonly

I assumed that 'e' was for 'extended' and that BPF stands for 'BSD Packet
Filter' originally described and specified in a paper titled "The BSD
Packet Filter: A New Architecture for User-level Packet Capture" by
Steven McCanne and Van Jacobson, presented at the 1993 Winter
USENIX Conference. This paper introduced the BPF architecture, which
was designed for efficient packet filtering and capture.

Hence a bit surprised why the first words of the first line in
the first paragraph of the draft abstract suggest that its
not an acronym?

105 14 [RFC2119] _RFC8174 <https://www.rfc-editor.org/info/rfc8174>__

This text seems to need an editorial edit

@dthaler dthaler added the ISA Affects ISA draft label Jun 20, 2024
@dthaler
Copy link
Collaborator Author

dthaler commented Jun 20, 2024

@dthaler
Copy link
Collaborator Author

dthaler commented Jun 23, 2024

Proposed patch for the acronym comment posted in https://mailarchive.ietf.org/arch/msg/bpf/G0yjlzZ4GazyQC2gN0jW8YjqGkk/

dthaler added a commit that referenced this issue Jun 23, 2024
Addresses part of #160

Signed-off-by: Dave Thaler <[email protected]>
dthaler added a commit that referenced this issue Jun 23, 2024
Addresses part of #160

Signed-off-by: Dave Thaler <[email protected]>
@dthaler dthaler added have proposed text Proposed patch posted fixed in bpf-next Awaiting propagation to ebpf-docs and removed have proposed text Proposed patch posted labels Jun 23, 2024
dthaler added a commit to dthaler/ebpf-docs-1 that referenced this issue Jun 24, 2024
dthaler added a commit that referenced this issue Jun 24, 2024
@dthaler dthaler added fixed in editors copy Fixed in github repo and removed fixed in bpf-next Awaiting propagation to ebpf-docs labels Jun 24, 2024
@dthaler
Copy link
Collaborator Author

dthaler commented Jun 25, 2024

Fixed in draft -04

@dthaler dthaler added fixed in editors copy Fixed in github repo and removed fixed in editors copy Fixed in github repo labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in editors copy Fixed in github repo ISA Affects ISA draft
Projects
None yet
Development

No branches or pull requests

1 participant