Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISA: Eric Vyncke comments #159

Open
dthaler opened this issue Jun 20, 2024 · 3 comments
Open

ISA: Eric Vyncke comments #159

dthaler opened this issue Jun 20, 2024 · 3 comments
Labels
fixed in editors copy Fixed in github repo ISA Affects ISA draft

Comments

@dthaler
Copy link
Collaborator

dthaler commented Jun 20, 2024


COMMENT:

Nice document, easy to read and understand and the shepherd's write-up
companion is also clear.

Just two COMMENTs (no need to reply, but replies will be appreciated):

  1. like Gunter, having an expansion to "eBPF is related or is the successor of
    extended Berkeley Packet Filter" would comfort the readers about what they are
    reading.

  2. I find puzzling the absence of betoh16() in the presence of htobe16()
    functions.

@dthaler dthaler added the ISA Affects ISA draft label Jun 20, 2024
@dthaler
Copy link
Collaborator Author

dthaler commented Jun 20, 2024

@dthaler
Copy link
Collaborator Author

dthaler commented Jun 23, 2024

@dthaler dthaler added have proposed text Proposed patch posted fixed in bpf-next Awaiting propagation to ebpf-docs and removed have proposed text Proposed patch posted labels Jun 23, 2024
dthaler added a commit to dthaler/ebpf-docs-1 that referenced this issue Jun 24, 2024
dthaler added a commit that referenced this issue Jun 24, 2024
@dthaler dthaler added fixed in editors copy Fixed in github repo and removed fixed in bpf-next Awaiting propagation to ebpf-docs labels Jun 24, 2024
@dthaler
Copy link
Collaborator Author

dthaler commented Jun 25, 2024

Fixed in draft -04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in editors copy Fixed in github repo ISA Affects ISA draft
Projects
None yet
Development

No branches or pull requests

1 participant