From 9354ea4aeb0f65a0390adcb62519558e5cb9000d Mon Sep 17 00:00:00 2001 From: Dirk Adler Date: Sat, 25 Jan 2025 15:23:40 +0100 Subject: [PATCH] chore: fix cs --- src/RdKafka/TopicConf.php | 2 +- tests/RdKafka/Test/MockClusterTest.php | 68 +++++++++++++------------- tests/RdKafka/TopicConfTest.php | 3 +- 3 files changed, 36 insertions(+), 37 deletions(-) diff --git a/src/RdKafka/TopicConf.php b/src/RdKafka/TopicConf.php index 5b83a30..e64e663 100644 --- a/src/RdKafka/TopicConf.php +++ b/src/RdKafka/TopicConf.php @@ -40,7 +40,7 @@ public function dump(): array { $count = Library::new('size_t'); $dump = Library::rd_kafka_topic_conf_dump($this->topicConf, FFI::addr($count)); - $count = (int)$count->cdata; + $count = (int) $count->cdata; $result = []; for ($i = 0; $i < $count; $i += 2) { diff --git a/tests/RdKafka/Test/MockClusterTest.php b/tests/RdKafka/Test/MockClusterTest.php index 585b213..1794f52 100644 --- a/tests/RdKafka/Test/MockClusterTest.php +++ b/tests/RdKafka/Test/MockClusterTest.php @@ -30,11 +30,11 @@ protected function setUp(): void public function testCreateWithProducingAndConsuming(): void { $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(1, $clusterConfig); $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); + $producerConfig->set('log_level', (string) LOG_EMERG); $producerConfig->set('bootstrap.servers', $cluster->getBootstraps()); $producer = new Producer($producerConfig); $producerTopic = $producer->newTopic(KAFKA_TEST_TOPIC); @@ -42,7 +42,7 @@ public function testCreateWithProducingAndConsuming(): void $producer->flush(KAFKA_TEST_LONG_TIMEOUT_MS); $consumerConfig = new Conf(); - $consumerConfig->set('log_level', (string)LOG_EMERG); + $consumerConfig->set('log_level', (string) LOG_EMERG); $consumerConfig->set('bootstrap.servers', $cluster->getBootstraps()); $consumerConfig->set('group.id', __METHOD__); $consumer = new KafkaConsumer($consumerConfig); @@ -65,8 +65,8 @@ public function testFromProducer(): void $this->requiresLibrdkafkaVersion('>=', '1.4.0'); $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); - $producerConfig->set('test.mock.num.brokers', (string)3); + $producerConfig->set('log_level', (string) LOG_EMERG); + $producerConfig->set('test.mock.num.brokers', (string) 3); $producer = new Producer($producerConfig); $cluster = MockCluster::fromProducer($producer); @@ -79,7 +79,7 @@ public function testFromProducerWithMissingConfigShouldFail(): void $this->requiresLibrdkafkaVersion('>=', '1.4.0'); $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); + $producerConfig->set('log_level', (string) LOG_EMERG); $producer = new Producer($producerConfig); $this->expectException(Exception::class); @@ -90,7 +90,7 @@ public function testFromProducerWithMissingConfigShouldFail(): void public function testGetBootstraps(): void { $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(3, $clusterConfig); $bootstrap = $cluster->getBootstraps(); @@ -105,7 +105,7 @@ public function testSetApiVersion(): void $logStack = []; $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(1, $clusterConfig); $cluster->setApiVersion(ApiKey::Produce, 4, 6); @@ -138,13 +138,13 @@ function (Producer $producer, int $level, string $fac, string $buf) use (&$logSt public function testSetPartitionFollowerAndLeader(): void { $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(2, $clusterConfig); $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); + $producerConfig->set('log_level', (string) LOG_EMERG); $producerConfig->set('bootstrap.servers', $cluster->getBootstraps()); - $producerConfig->set('topic.metadata.refresh.interval.ms', (string)50); + $producerConfig->set('topic.metadata.refresh.interval.ms', (string) 50); $producer = new Producer($producerConfig); $producerTopic = $producer->newTopic(KAFKA_TEST_TOPIC); @@ -168,7 +168,7 @@ public function testSetPartitionFollowerAndLeader(): void public function testSetPartitionFollowerWatermarks(): void { $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(3, $clusterConfig); $cluster->setPartitionLeader(KAFKA_TEST_TOPIC, 0, 1); @@ -176,9 +176,9 @@ public function testSetPartitionFollowerWatermarks(): void // produce 10 msgs $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); + $producerConfig->set('log_level', (string) LOG_EMERG); $producerConfig->set('bootstrap.servers', $cluster->getBootstraps()); - $producerConfig->set('batch.num.messages', (string)1); + $producerConfig->set('batch.num.messages', (string) 1); $producer = new Producer($producerConfig); $producerTopic = $producer->newTopic(KAFKA_TEST_TOPIC); for ($i = 0; $i < 10; $i++) { @@ -188,11 +188,11 @@ public function testSetPartitionFollowerWatermarks(): void // prepare consumer $consumerConfig = new Conf(); - $consumerConfig->set('log_level', (string)LOG_EMERG); + $consumerConfig->set('log_level', (string) LOG_EMERG); $consumerConfig->set('group.id', __METHOD__); $consumerConfig->set('auto.offset.reset', 'earliest'); - $consumerConfig->set('fetch.min.bytes', (string)100); - $consumerConfig->set('fetch.message.max.bytes', (string)1000); + $consumerConfig->set('fetch.min.bytes', (string) 100); + $consumerConfig->set('fetch.message.max.bytes', (string) 1000); $consumerConfig->set('bootstrap.servers', $cluster->getBootstraps()); $consumer = new KafkaConsumer($consumerConfig); $consumer->assign([new TopicPartition(KAFKA_TEST_TOPIC, 0, RD_KAFKA_OFFSET_INVALID)]); @@ -261,13 +261,13 @@ public function testSetBrokerDownAndUp(): void $this->requiresLibrdkafkaVersion('>=', '1.4.0'); $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(1, $clusterConfig); $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); + $producerConfig->set('log_level', (string) LOG_EMERG); $producerConfig->set('bootstrap.servers', $cluster->getBootstraps()); - $producerConfig->set('reconnect.backoff.max.ms', (string)1000); + $producerConfig->set('reconnect.backoff.max.ms', (string) 1000); $producer = new Producer($producerConfig); $cluster->setBrokerDown(1); @@ -291,12 +291,12 @@ public function testSetBrokerDownAndUp(): void public function testPushRequestErrors(): void { $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(1, $clusterConfig); // produce msg $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); + $producerConfig->set('log_level', (string) LOG_EMERG); $producerConfig->set('bootstrap.servers', $cluster->getBootstraps()); $producer = new Producer($producerConfig); $producerTopic = $producer->newTopic(KAFKA_TEST_TOPIC); @@ -313,7 +313,7 @@ public function testPushRequestErrors(): void // try to consume msg $consumerConfig = new Conf(); - $consumerConfig->set('log_level', (string)LOG_EMERG); + $consumerConfig->set('log_level', (string) LOG_EMERG); $consumerConfig->set('group.id', __METHOD__); // $consumerConfig->set('debug', 'fetch'); $consumerConfig->set('bootstrap.servers', $cluster->getBootstraps()); @@ -333,12 +333,12 @@ public function testPushRequestErrorsArray(): void $this->requiresLibrdkafkaVersion('>=', '1.7.0'); $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(1, $clusterConfig); // produce msg $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); + $producerConfig->set('log_level', (string) LOG_EMERG); $producerConfig->set('bootstrap.servers', $cluster->getBootstraps()); $producer = new Producer($producerConfig); $producerTopic = $producer->newTopic(KAFKA_TEST_TOPIC); @@ -357,7 +357,7 @@ public function testPushRequestErrorsArray(): void // try to consume msg $consumerConfig = new Conf(); - $consumerConfig->set('log_level', (string)LOG_EMERG); + $consumerConfig->set('log_level', (string) LOG_EMERG); $consumerConfig->set('group.id', __METHOD__); // $consumerConfig->set('debug', 'fetch'); $consumerConfig->set('bootstrap.servers', $cluster->getBootstraps()); @@ -377,12 +377,12 @@ public function testCreateTopic(): void $this->requiresLibrdkafkaVersion('>=', '1.4.0'); $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(1, $clusterConfig); $cluster->createTopic(KAFKA_TEST_TOPIC, 12, 1); $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); + $producerConfig->set('log_level', (string) LOG_EMERG); $producerConfig->set('bootstrap.servers', $cluster->getBootstraps()); $producer = new Producer($producerConfig); $producerTopic = $producer->newTopic(KAFKA_TEST_TOPIC); @@ -401,12 +401,12 @@ public function testPushBrokerRequestErrors(): void $this->requiresLibrdkafkaVersion('<', '1.7.0'); $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(1, $clusterConfig); // produce msg $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); + $producerConfig->set('log_level', (string) LOG_EMERG); $producerConfig->set('bootstrap.servers', $cluster->getBootstraps()); $producer = new Producer($producerConfig); $producerTopic = $producer->newTopic(KAFKA_TEST_TOPIC); @@ -424,7 +424,7 @@ public function testPushBrokerRequestErrors(): void // try to consume msg $consumerConfig = new Conf(); - $consumerConfig->set('log_level', (string)LOG_EMERG); + $consumerConfig->set('log_level', (string) LOG_EMERG); $consumerConfig->set('group.id', __METHOD__); // $consumerConfig->set('debug', 'fetch'); $consumerConfig->set('bootstrap.servers', $cluster->getBootstraps()); @@ -444,12 +444,12 @@ public function testPushBrokerRequestErrorRtts(): void $this->requiresLibrdkafkaVersion('>=', '1.7.0'); $clusterConfig = new Conf(); - $clusterConfig->set('log_level', (string)LOG_EMERG); + $clusterConfig->set('log_level', (string) LOG_EMERG); $cluster = MockCluster::create(1, $clusterConfig); // produce msg $producerConfig = new Conf(); - $producerConfig->set('log_level', (string)LOG_EMERG); + $producerConfig->set('log_level', (string) LOG_EMERG); $producerConfig->set('bootstrap.servers', $cluster->getBootstraps()); $producer = new Producer($producerConfig); $producerTopic = $producer->newTopic(KAFKA_TEST_TOPIC); @@ -469,7 +469,7 @@ public function testPushBrokerRequestErrorRtts(): void // try to consume msg $consumerConfig = new Conf(); - $consumerConfig->set('log_level', (string)LOG_EMERG); + $consumerConfig->set('log_level', (string) LOG_EMERG); $consumerConfig->set('group.id', __METHOD__); // $consumerConfig->set('debug', 'fetch'); $consumerConfig->set('bootstrap.servers', $cluster->getBootstraps()); diff --git a/tests/RdKafka/TopicConfTest.php b/tests/RdKafka/TopicConfTest.php index 48bbf9e..8a3c938 100644 --- a/tests/RdKafka/TopicConfTest.php +++ b/tests/RdKafka/TopicConfTest.php @@ -184,8 +184,7 @@ public function testSetPartitionerCbWithCallback(): void $topicConf->setOpaque($expectedTopicOpaque); $topicConf->setPartitionerCb( function (?string $key, int $partitionCount, ?object $topic_opaque = null, ?object $message_opaque = null) use ( - & - $callbackTopicOpaque, + &$callbackTopicOpaque, &$callbackMessageOpaque ) { $callbackTopicOpaque = $topic_opaque;