Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empirical Probability Calculation Error for SEAS51 Data #2

Open
nishadhka opened this issue Jul 18, 2024 · 0 comments
Open

Empirical Probability Calculation Error for SEAS51 Data #2

nishadhka opened this issue Jul 18, 2024 · 0 comments

Comments

@nishadhka
Copy link
Member

The get_mean_ens_triggers function (

fct_mod = (ens_data <= mod_thr).mean(dim="member")
) is currently miscalculating empirical probabilities when applied to SEAS51 forecast data. The issue stems from the differing number of ensemble members over time:

  • 198101-201612: 26 members
  • 201701-present: 51 members

The current implementation (fct_mod = (ens_data <= mod_thr).mean(dim="member")) incorrectly assumes 51 members for the entire period, leading to erroneous probability calculations.

Technical Details:

  • The dim="member" argument in .mean() calculates the average across all members, regardless of whether they are present in the data for a given time period.
  • This results in the average being artificially lowered for the earlier period (198101-201612) where there are fewer members.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant