Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial gawen #36

Merged
merged 16 commits into from
Jun 4, 2021
Merged

Tutorial gawen #36

merged 16 commits into from
Jun 4, 2021

Conversation

GawenMonnot
Copy link
Contributor

Fixes #35 .

Changes proposed in this pull request:

  • Added a tutorial about how to extract data
  • Added a error's page to help developers

It is a pretty long tutorial. I would like feedbacks :

  • is it clear enough ?
  • is it too long ? Not enough ?
    -...

I decided to do the tutorial on a data pretty hard to exploit ; if needed, I can do it again with an easier data structure.
There may be English mistakes, I will try to correct them later.

@GawenMonnot GawenMonnot requested a review from dkastl June 4, 2021 13:30
Copy link
Member

@dkastl dkastl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great tutorial!
Since this is a collaborative effort, if someone wants to add or change something, they are able to do so.

The only thing I'm not sure about is, where we should store images that belong to the documentation. We could also store them in the same directory as the document itself, which will make it easier to reference them in Markdown rather than having to go two directories up first.

@dkastl
Copy link
Member

dkastl commented Jun 4, 2021

Not sure why the Github Actions "check" fails. I actually dont even remember why it is there ... but it was me who added it ;-)

@GawenMonnot
Copy link
Contributor Author

This is great tutorial!
Since this is a collaborative effort, if someone wants to add or change something, they are able to do so.

The only thing I'm not sure about is, where we should store images that belong to the documentation. We could also store them in the same directory as the document itself, which will make it easier to reference them in Markdown rather than having to go two directories up first.

I agree. I am going to change this.

@GawenMonnot GawenMonnot merged commit 77d9335 into main Jun 4, 2021
@GawenMonnot GawenMonnot deleted the tutorial_gawen branch June 8, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial
2 participants