Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA4GH conform stdout/stderr logging #104

Open
bnwlf opened this issue Nov 10, 2020 · 1 comment
Open

GA4GH conform stdout/stderr logging #104

bnwlf opened this issue Nov 10, 2020 · 1 comment
Assignees
Labels
new-feature Request is a new feature

Comments

@bnwlf
Copy link

bnwlf commented Nov 10, 2020

Hi together!
The GA4GH standard for a WES server assumes accessible stdout and stderr logs at the rest API. Currently, the fields are provided but empty. I know that the nextflow weblog is not capabile to provide that information. Nevertheless, standard conformity in this point would be nice!
I think it should be possible to access this data via the nextflow log functionallity or by accessing the k8s logs of the pod. Probably it would be a wise decision to implement a switch (maybe opt-in) for this feature since it could waste much disk space. This feature could help to debug workflows by the users themselves.
Example: the nextflow hello example quits with an empty output.
Thanks !
Ben

@bnwlf bnwlf added the new-feature Request is a new feature label Nov 10, 2020
@lepsalex
Copy link
Contributor

Hi Ben!

stderr should be populating when there is an error, that is currently how we view all of our errors both using the WES REST API as well as our GQL extension. That said, stdout is just empty as you observed. This is on our roadmap to add but just hasn't been a high enough priority for us internally.

As you said, Nextflow weblog does not provide this functionality so our options are to fork Nextflow and add it (something we want to avoid), or to do something on the K8s side as we've done to solve other issues. The only issue with that is since we are planning on supporting other platforms such as SGE we would need to reimplement that solution for each one which is also not ideal. I've also looked at the Nextflow logs command and I think something like that would be ideal, we just need to get the resources to design and implement the solution.

Obviously stderr needs to be there right away so can you confirm that you are not seeing error logs on jobs with state EXECUTOR_ERROR?

Secondly, how much is not having stdout impacting you for what you are doing now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Request is a new feature
Projects
None yet
Development

No branches or pull requests

3 participants