Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store metadata in dtype #15

Open
mlincett opened this issue Jul 29, 2023 · 0 comments
Open

Do not store metadata in dtype #15

mlincett opened this issue Jul 29, 2023 · 0 comments

Comments

@mlincett
Copy link
Contributor

It seems we use the numpy dtype.metadata to carry (event) metadata over in the nside dictionary.

I find pretty counter-intuitive to have metadata of the data embedded in the dtype, but I understand this may be the only numpy-supported way for storing metadata in npz files.

Since we are moving towards JSON as a primary exchange format, I suggest to migrate all the dtype.metadata logic in to_npz() and read_npz(), so that this "feature" is no longer part of the core class design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant