Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal Source and mass mixing classes with models from snewpy. #60

Closed
sybenzvi opened this issue Nov 29, 2021 · 1 comment
Closed

Replace internal Source and mass mixing classes with models from snewpy. #60

sybenzvi opened this issue Nov 29, 2021 · 1 comment
Assignees
@sybenzvi @sgriswol
Labels
enhancement New feature or request high priority This should be taken care of as soon as possible

Comments

@sybenzvi
Copy link
Collaborator

Since snewpy has standardized access to a number of CCSN models and flavor transformation scenarios, we should pull it in as a dependency. This would entail deleting the Source class in the source module, but keeping the functionality of the photonic_energy_per_vol member function.

About flavor transformations, we can probably completely remove the oscillations module and use the transformation classes implemented in snewpy.
@sybenzvi sybenzvi added enhancement New feature or request high priority This should be taken care of as soon as possible labels Nov 29, 2021
@sybenzvi sybenzvi mentioned this issue Dec 15, 2021
Merged
@sgriswol
Copy link
Collaborator

Resolved by #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sybenzvi sybenzvi

@sgriswol sgriswol

Labels
enhancement New feature or request high priority This should be taken care of as soon as possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sybenzvi @sgriswol