Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-length simulations are not performed #105

Closed
sgriswol opened this issue Jul 1, 2024 · 0 comments · Fixed by #106
Closed

Short-length simulations are not performed #105

sgriswol opened this issue Jul 1, 2024 · 0 comments · Fixed by #106
Assignees
Labels
bug Something isn't working

Comments

@sgriswol
Copy link
Collaborator

sgriswol commented Jul 1, 2024

To optimize memory usage, a limit of 1000 * DIM(E) operations was imposed on the core calculation compute_photonic_energy_per_vol. However, in the case that a time array of less than 1000 elements is requested, no simulation is performed.

Thanks to @jakob2508 and E. Tintinger for finding this!

@sgriswol sgriswol self-assigned this Jul 1, 2024
@sgriswol sgriswol added the bug Something isn't working label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant