PostgreSQL 17 support

[devrimgunduz]

Hi,

PostgreSQL 17 Beta1 is out. firebird_fdw fails to build against v17. I had to edit Makefile to add 17, but still:

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fPIC -fvisibility=hidden -I. -I./ -I/usr/pgsql-17/include/server -I/usr/pgsql-17/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -DWITH_GZFILEOP -I/usr/include -c -o src/firebird_fdw.o src/firebird_fdw.c
src/firebird_fdw.c: In function ‘firebirdGetForeignPaths’:
src/firebird_fdw.c:1224:26: error: too few arguments to function ‘create_foreignscan_path’
1224 | create_foreignscan_path(root, baserel,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from src/firebird_fdw.c:50:
/usr/pgsql-17/include/server/optimizer/pathnode.h:125:21: note: declared here
125 | extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,
| ^~~~~~~~~~~~~~~~~~~~~~~

Can you please take a look?

Thanks!

Cheers, Devrim

[ibarwick]

Hi Devrim

You seem to be using outdated sources, please check the 1.4.0 release: https://github.com/ibarwick/firebird_fdw/releases/tag/1.4.0

Note there's also a corresponding libfq release: https://github.com/ibarwick/libfq/releases/tag/0.6.1

[devrimgunduz]

Hi Ian,

Sorry :( I thought I checked, but apparently I did not :(

Cheers, Devrim