Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding gulp-sass to "With Gulp" workflow section #2

Open
adamjohnson opened this issue Mar 19, 2015 · 5 comments
Open

Consider adding gulp-sass to "With Gulp" workflow section #2

adamjohnson opened this issue Mar 19, 2015 · 5 comments

Comments

@adamjohnson
Copy link

On this page:

http://pleeease.io/workflow/#with-gulp

You have an example gulpfile that uses gulp-ruby-sass. Would you consider adding a link or something similar that uses gulp-sass with gulp-sourcemaps? I have an example project + gulpfile that uses all of these things here:

http://cl.ly/aHru (zip)
danielhusar/gulp-pleeease#3 (comment)

It seems like the Gulp community is starting to favor gulp-sourcemaps and it's becoming widely used between Autoprefixer, gulp-sass, and other pre and post processors.


I really dig Pleeease. Thanks for all your work Vincent.

@iamvdo
Copy link
Owner

iamvdo commented Mar 23, 2015

Hi Adam,

Thanks for your sample, but I can't make it work. Which version of pleeease are you using ?

PS: I've made many changes in sourcemaps creation, and I'm currently rewriting gulp-pleeease, to get these modifications. Moreover, as I've added preprocessors into pleeease, I'm also trying to make them work without using gulp-sass, nor gulp-ruby-sass, but it's a bit harder than expected.

@adamjohnson
Copy link
Author

Here's the versions of what I'm using:

https://s3.amazonaws.com/f.cl.ly/items/1P1q2Z1L2g0s0h060V26/versions.png

Looks like gulp-pleeease v1.2.0 with pleeease v3.2.4.

@iamvdo
Copy link
Owner

iamvdo commented Mar 23, 2015

I have the exact same config, but sourcemaps doesn't work. First I have 2 sourceMappingURL in final file: one base64 encoded and one referencing the map file (this is resolved in next gulp-pleeease)

/*# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbIm1haW4uY3NzIl0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiJBQUFBO0VBQ0UsYUFBWSxFQUFFOztBQUVoQjtFQUNFLGlCQUFnQjtFQUFoQixpQkFBZ0IsRUFBRTs7QUFFcEI7RUFDRSxxQkFBb0IsRUFBRTs7QUFFeEI7RUFDRSxnREFBdUM7VUFBdkMsd0NBQXVDO0VBQ3ZDLFlBQVc7RUFDWCxzQkFBYztFQUFkLHVCQUFjO0VBQWQsc0JBQWM7RUFBZCxlQUFjO0VBQ2QsOEJBQVM7RUFBVCxrQkFBUztNQUFULG1CQUFTO1VBQVQsVUFBUztFQUNULGlCQUFnQjtFQUFoQixpQkFBZ0IsRUFBRTs7QUFFcEI7RUFDRSxhQUFZO0VBQ1osb0JBQW1CO0VBQ25CLHVEQUE4QztVQUE5QywrQ0FBOEMsRUFBRTs7QUFFbEQ7RUFDRSxtQkFBa0IsRUFBRSIsImZpbGUiOiI8bm8tb3V0cHV0PiIsInNvdXJjZXNDb250ZW50IjpbImgyIHtcbiAgY29sb3I6IGJsdWU7IH1cblxuaDMge1xuICBmb250LXNpemU6IDVyZW07IH1cblxuYm9keSB7XG4gIGJhY2tncm91bmQ6ICNlYWVhZWE7IH1cblxuaDEge1xuICB0cmFuc2l0aW9uOiBiYWNrZ3JvdW5kLWNvbG9yIDAuNXMgZWFzZTtcbiAgY29sb3I6IHJlZDtcbiAgZGlzcGxheTogZmxleDtcbiAgb3JkZXI6IDE7XG4gIGZvbnQtc2l6ZTogNHJlbTsgfVxuXG4uZXhhbXBsZSB7XG4gIGZsb2F0OiBsZWZ0O1xuICBiYWNrZ3JvdW5kOiBvcmFuZ2U7XG4gIHRyYW5zaXRpb246IGJhY2tncm91bmQtY29sb3IgMC4zcyBlYXNlLWluLW91dDsgfVxuXG4uZXhhbXBsZTpob3ZlciB7XG4gIGJhY2tncm91bmQ6IGdyZWVuOyB9XG5cbiJdfQ== */
/*# sourceMappingURL=main.css.map */

Can you share your final CSS and MAP files?

Oops, files are in the ZIP. So, we have the same result. How could this work for you ?

@adamjohnson
Copy link
Author

I only tried in Chrome 41 on OSX. Firefox doesn't want to display the original SCSS file.

Dev Tools Settings:

dev-tools-settings

They work, promise!

osx-chrome-41

You might try closing and reopening dev tools? I had to do that after the first time I generated them.

@iamvdo
Copy link
Owner

iamvdo commented Mar 27, 2015

Hey!

Maybe you can help ? :)

danielhusar/gulp-pleeease#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants