Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Execution workflow): LABRAT feature to reuse previous makeTFfasta output #406

Open
mrgazzara opened this issue Aug 9, 2022 · 2 comments
Labels
enhancement New feature or request low priority Not important at the moment

Comments

@mrgazzara
Copy link
Collaborator

mrgazzara commented Aug 9, 2022

Labrat takes very long time to run in its current implementation of the execution workflow. This is because the makeTFfasta step takes several days (~3.5 when I ran it). The subsequent Salmon steps take next to no time to run. It would be a useful feature to allow users to pass to the execution workflow the result of the makeTFfasta step from a previous execution to speed things up. The makeTFfasta step should only have to be run once per annotation version.

Any thoughts on this possibility @yuukiiwa or @dominikburri ?

@mrgazzara mrgazzara added enhancement New feature or request low priority Not important at the moment labels Aug 9, 2022
@dominikburri
Copy link
Collaborator

Hi @mrgazzara, good point.
One quick fix could be to run several samples at once, e.g. having the sample table with all Mayr samples. In this way the makeTFfasta should only be executed once. Or is this how you executed it so far?
Alternatively, I can imagine to restructure nextflow in that makeTFfasta would be treated as a parameter and only executed/created when not existing. Similar to what @faricazjj did in IsoSCM, see here:

run_star_genome_generate = false

@mrgazzara
Copy link
Collaborator Author

Yes the latter is exactly what I had in mind. We also do something very similar with the QAPA EWF where you can chose to build a new 3'UTR annotation file or re-use an existing annotation. Something like that would be a huge time saver for users of our Labrat EWF.

@ninsch3000 ninsch3000 changed the title Execution Workflow: LABRAT feature to reuse previous makeTFfasta output feat [Execution workflow]: LABRAT feature to reuse previous makeTFfasta output Aug 9, 2023
@ninsch3000 ninsch3000 changed the title feat [Execution workflow]: LABRAT feature to reuse previous makeTFfasta output feat(Execution workflow): LABRAT feature to reuse previous makeTFfasta output Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Not important at the moment
Projects
None yet
Development

No branches or pull requests

2 participants