-
Notifications
You must be signed in to change notification settings - Fork 46
Rotated column headers #78
base: master
Are you sure you want to change the base?
Conversation
Set rotated column headers and link to switch between ranked and alphabetically sorted list.
Ah... I forgot to test this on IE. This should probably be done before taking the HTML live. |
Hi, is there a way we can make this scale 100% screen width. I appreciate the idea and the fact that it now fits on smaller screens; but on large screen it just looks like wasted space if there is so much white on the right hand side. |
You are right, I missed that. I set the table width to 100%, this should do the trick. |
I added one more line (and two imports) to the output of the ComplianceTester to print out the version and the current time. The version should maybe be determined from some global source, but I am afraid I don't know how to do that. |
Hi, could you separate the actual header rotation from everything else like the order by link or the modification of the ComplianceTester output. I'd be happy to merge the header rotation right now but I'm not happy yet with the order by link (don't like how it looks. I agree though that this might be something useful to have.) |
You mean like this? (I hope it is correct, did not test the php, only my local html file) |
Sorry for the confusion; I actually meant the pull request. I wanted a seperate pull request only for the header rotation that does not include the sort link and doesn't touch the actual compliance tester. I wasn't talking about the the CSS logic. I actually don't have an opinion on the CSS. |
I don't really know how to handle this on github, so I just removed the mentioned code for now. |
I just realized that the column width of the first column with the servers in it gets too wide on larger screens. I added some more CSS to reduce the width of it to a minimum. |
There is another issue that the description of the right most column makes
the table expand beyond 100% which creates horizontal scrollbars
|
I saw it and added a padding to the right of the table. |
I'd really like to see this merged as imo the table is hard to use because it's too wide at the moment, especially on mobile devices. |
Set rotated column headers and add a link to switch between ranked and alphabetically sorted list.
There is also a new column "last update" which is currently commented out. I don't know if the date of the last update of a specific report can be determined somehow. Maybe a timestamp could be added in the report and that one could be parsed then?