Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute the radial profile Dens*Ye and compute Pres from radial profiles. #112

Open
Inhyeok-Song opened this issue Dec 26, 2023 · 0 comments · Fixed by #114
Open

Compute the radial profile Dens*Ye and compute Pres from radial profiles. #112

Inhyeok-Song opened this issue Dec 26, 2023 · 0 comments · Fixed by #114
Assignees
Labels

Comments

@Inhyeok-Song
Copy link
Collaborator

It does more make sense that we compute the radial profile Dens*Ye and compute Pres from radial profiles
rather than directly compute Pres.

There are two versions about this issue, and it is better to combine those two.

ccsn_grep_corr_v1 : discard bins containing unphysical values
ccsn_grep_corr_v2 : compute the radial profile of Ye * Dens first, and compute pressure from the radial profiles

@hyschive hyschive linked a pull request Mar 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants