-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to best distribute the CSS file? #17
Comments
We should definitely at least be distributing it in the package. I'm not as sure what the best way is to include it. I like CSS Modules but I'm not sure how well supported that is yet, or what would be required tooling-wise for downstream users. Also when the class names get hashed, does it make it harder for users to customize? My instinct here is to ship the CSS file directly. We might want to add General question: would it work to do in javascript |
FYI it is actually distributed in the npm package, in the |
In hyparam/hyperparam-cli#141 and hyparam/space#13, I do: import 'hightable/src/HighTable.css' and remove the duplicate (and outdated) HighTable.css files from these repos. Two comments:
|
The file Hightable.css is not distributed in the npm package. Users who want to use it have to copy it from the repository.Should we include it in the package as a CSS module (see how Vite handles them: https://vite.dev/guide/features#css-modules - rollup also has some packages to handle them)?
The text was updated successfully, but these errors were encountered: