ERROR: Service 'hygieia' failed to build: ADD failed: no source files were specified

[drewkhoury]

Running docker-compose up -d results in:

Creating network "hygieia-starter-kit_default" with the default driver
Building hygieia
Step 1/18 : FROM hygieiadoc/hygieia-starter-base:latest
latest: Pulling from hygieiadoc/hygieia-starter-base
a02a4930cb5d: Pull complete
c702ea4a22bc: Pull complete
6a38198d9c6b: Pull complete
ca72338e4013: Pull complete
0c1303a0f7b7: Pull complete
ec4147295636: Pull complete
cee22259ab20: Pull complete
1bb83904da6e: Pull complete
0daae6d21fc1: Pull complete
8a784066ab6a: Pull complete
6a3efd1a5f8d: Pull complete
3dee5bb1478d: Pull complete
9d07c5ae2c30: Pull complete
Digest: sha256:834fdf76f1189a65090fec05b63d3ec46c288c1e0a118972bd12dba9a326d9d8
Status: Downloaded newer image for hygieiadoc/hygieia-starter-base:latest
 ---> 0c2db0a44853
Step 2/18 : EXPOSE 8080
 ---> Running in 9cec7ba7b835
Removing intermediate container 9cec7ba7b835
 ---> 55ee784eaa3a
Step 3/18 : EXPOSE 80
 ---> Running in d00c3010d2e4
Removing intermediate container d00c3010d2e4
 ---> 43845159eaf1
Step 4/18 : EXPOSE 27017
 ---> Running in 3cf1dcf8088c
Removing intermediate container 3cf1dcf8088c
 ---> 06b6c00b604a
Step 5/18 : ENV JAVA_HOME /usr/lib/jvm/java-openjdk
 ---> Running in 4807d1611041
Removing intermediate container 4807d1611041
 ---> 7c97a5f64402
Step 6/18 : ENV PROP_FILE /hygieia/application.properties
 ---> Running in a3dbf83cbb81
Removing intermediate container a3dbf83cbb81
 ---> 6383408d6fc9
Step 7/18 : COPY /api/* /hygieia/api/
 ---> fb1989bbdae9
Step 8/18 : COPY /system/* /etc/systemd/system/
 ---> adc9d35c1d01
Step 9/18 : COPY /collectors/* /hygieia/collectors/
 ---> d1bf977fe3b3
Step 10/18 : COPY /ui/httpd.conf /etc/httpd/conf/
 ---> af078243496e
Step 11/18 : ADD /certs/* /hygieia/cacerts/
ERROR: Service 'hygieia' failed to build: ADD failed: no source files were specified

[drewkhoury]

The issue is due to no certs folder (or no files in certs folder).

Ideally suppling a cert in the certs folder would allow for this to work regardless of the user adding their own certs, else step 12 will fail without any custom certs added.

Also I don't think ADD is required, COPY steps should work just fine for all steps in this Dockerfile.

I solved the issue by commenting out the certs step, however I think we should either supply at least one cert or add a comment in the README to comment the step out if you're not going to add a cert.

[rvema]

@Sbrenthughes can you address this issue when you have some time?