Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-UTC timezone handling #103

Open
gartavanis opened this issue Sep 27, 2024 · 0 comments
Open

Non-UTC timezone handling #103

gartavanis opened this issue Sep 27, 2024 · 0 comments

Comments

@gartavanis
Copy link
Contributor

When the start and end dates cross the time change boundary (e.g. EST->EDT) the code can return one day more forcing data than requested. This should not be an issue, except in the case that the dataset ends and the additional day "falls off the edge".

To fix this, instead of calculating start and end dates separately, the time interval between the original UTC dates should be added to the new timezone start date in order to calculate the new end date. This should be done in all points in the code where end dates are converted from UTC to another timezone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant