Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Reverb #7

Open
composition4 opened this issue Sep 10, 2017 · 2 comments
Open

Feature: Add Reverb #7

composition4 opened this issue Sep 10, 2017 · 2 comments

Comments

@composition4
Copy link

This, as a placeholder for coming PR (and discussion).

@neauoire
Copy link
Member

Sure :)

@composition4
Copy link
Author

composition4 commented Sep 10, 2017

Issues with fileIO at the moment prevent convolution filter as well as possible conflict of licensing & dependency on impulse data (ogg).

Aside from simple echo provided, article recommends using FFT/blur to handle simple reverb (also mentions using multiple delay streams).

Suggest initial prototype using FFT, avoiding blur for now until further testing proves its requirement. I'll work on this as best as possible however refactoring of jammer.js & player-worker.js may eventually need to be done for handling stream data more efficiently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants