You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
The current web3Signup function is registering oracles in the kvstore of either Polygon or Amoy network, depending on the environment. However, this functionality should be improved by adding a chainId, allowing users to specify the exact network where they want to register the oracle. This ensures that users have control over which network the oracle is registered on.
Motivation
Currently, the web3Signup function assumes the network based on the environment, which limits multinetwork functionality (Oracles cannot be registered in others reputation networks). By introducing chainId, users can explicitly choose the network where they want to register the oracle. This also helps prevent potential conflicts where an oracle might be unintentionally registered on the wrong network.
Implementation details
Add a chainId parameter to the web3Signup endpoint of the Reputation Oracle.
Before setting the kvstore, add a verification step to ensure that the value has not already been set. If it has, return an appropriate error message indicating that the kvstore cannot be overwritten.
Test these changes across multiple networks to ensure proper behavior and error handling.
The text was updated successfully, but these errors were encountered:
Description
The current
web3Signup
function is registering oracles in the kvstore of either Polygon or Amoy network, depending on the environment. However, this functionality should be improved by adding achainId
, allowing users to specify the exact network where they want to register the oracle. This ensures that users have control over which network the oracle is registered on.Motivation
Currently, the web3Signup function assumes the network based on the environment, which limits multinetwork functionality (Oracles cannot be registered in others reputation networks). By introducing
chainId
, users can explicitly choose the network where they want to register the oracle. This also helps prevent potential conflicts where an oracle might be unintentionally registered on the wrong network.Implementation details
The text was updated successfully, but these errors were encountered: