Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reputation Oracle] Multichain Web3 Sign Up #2618

Open
flopez7 opened this issue Oct 9, 2024 · 0 comments
Open

[Reputation Oracle] Multichain Web3 Sign Up #2618

flopez7 opened this issue Oct 9, 2024 · 0 comments

Comments

@flopez7
Copy link
Contributor

flopez7 commented Oct 9, 2024

Description
The current web3Signup function is registering oracles in the kvstore of either Polygon or Amoy network, depending on the environment. However, this functionality should be improved by adding a chainId, allowing users to specify the exact network where they want to register the oracle. This ensures that users have control over which network the oracle is registered on.

Motivation
Currently, the web3Signup function assumes the network based on the environment, which limits multinetwork functionality (Oracles cannot be registered in others reputation networks). By introducing chainId, users can explicitly choose the network where they want to register the oracle. This also helps prevent potential conflicts where an oracle might be unintentionally registered on the wrong network.

Implementation details

  • Add a chainId parameter to the web3Signup endpoint of the Reputation Oracle.
  • Before setting the kvstore, add a verification step to ensure that the value has not already been set. If it has, return an appropriate error message indicating that the kvstore cannot be overwritten.
  • Test these changes across multiple networks to ensure proper behavior and error handling.
@portuu3 portuu3 moved this to Todo in Core-tech - 2024 Oct 9, 2024
@portuu3 portuu3 moved this from Todo to Icebox in Core-tech - 2024 Oct 9, 2024
@portuu3 portuu3 moved this from Icebox to Backlog in Core-tech - 2024 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant