Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark background #1024

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Add dark background #1024

merged 3 commits into from
Jan 28, 2025

Conversation

BernatBC
Copy link
Member

Issue

Description

You can set the background for the dark mode in hugo.yaml.

# Site parameters
params:
  # Background image of the landing page
  background: "images/background.jpg"
  darkBackground: "images/background_dark.jpg"

Test Evidence

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit 2fce9d2
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/6798f06bf7aede00082647a9
😎 Deploy Preview https://deploy-preview-1024--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Jan 17, 2025
Closed
Open
@niltied
Copy link
Contributor

niltied commented Jan 22, 2025 •
edited
Loading

Hi @BernatBC,

When the PR is approved, don't forget to add this new instruction in the user guides.

I think adding it as "commented out" after the background instruction in the examples would be a good idea. Simply including the instruction in the complete configuration file available as an example in the repository is not enough.

What do you think ?

@BernatBC BernatBC mentioned this pull request Jan 25, 2025
Merged
@BernatBC
Copy link
Member Author

HI @niltied, thank you for reminding me about it. I've just created a PR with those changes. Could you please review the French translation?
Thank you!

@niltied
Copy link
Contributor

niltied commented Jan 28, 2025

Hi @BernatBC, it's done 👍🏻

hugo-toha/guides#321

@hossainemruz
Copy link
Member

@BernatBC You should have permission to merge the PR. Feel free to merge once it is approved.

@BernatBC BernatBC merged commit f8befe6 into hugo-toha:main Jan 28, 2025
11 of 13 checks passed
@BernatBC BernatBC deleted the add-dark-background branch January 28, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hossainemruz hossainemruz hossainemruz approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to set different background image for dark and light themes?
3 participants
@BernatBC @niltied @hossainemruz