fix: Qwen2-VL generate with inputs_embeds #35466
Open
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing |
zucchini-nlp
reviewed
Jan 6, 2025
There was a problem hiding this comment.
@minostauros hey, thanks for submitting s PR!
Unfortunately, we'd like to keep the RoPE delta related code withing the forward method as it has been causing errors in some generation techniques. The failing tests are also related to the rope deltas, some techniques call model's forward several times with the same inputs and thus position ids might not be correct in such cases. Is there any way to fix this by changing only the forward code?
I suggest to refactor a bit the get_repo_index and remove the dependency on input_ids as a required argument when no video/image is passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #35463
However, not so sure about the fix is correct. At least test I added works, but failing some existing tests.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@zucchini-nlp