Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Xcode 13.3.x fails with DEPRECATED error #981

Closed
fcr opened this issue Apr 13, 2022 · 8 comments
Closed

Build with Xcode 13.3.x fails with DEPRECATED error #981

fcr opened this issue Apr 13, 2022 · 8 comments

Comments

@fcr
Copy link
Collaborator

fcr commented Apr 13, 2022

Building htm.core with Xcode 13.3 or 13.3.1 fails with a DEPRECATED error. Xcode 13.2 works fine.
I've attached a partial console output:
xcode 13.3.1 error.txt
.
Build is run on Monterey 12.3.1 with Anaconda Python 3.9

If the change posted by @finnoshea is used, then the build with Xcode 13.3.1 succeeds and passes all unit tests.

@ctrl-z-9000-times
Copy link
Collaborator

I think PR #974 should fix this issue.

@fcr
Copy link
Collaborator Author

fcr commented Apr 13, 2022

Great. Thanks.

@fcr
Copy link
Collaborator Author

fcr commented Apr 14, 2022

I think PR #974 should fix this issue.

I am sorry to say that it didn't.
I still had to apply the change change #975 (comment) by @finnoshea in order to build.

@ctrl-z-9000-times
Copy link
Collaborator

Okay, thanks for reporting back to me about that.

  1. PR#974 removed the file that was causing the error in the log that you posted, so I'm assuming that now you're hitting another error.

  2. I'm going to see about pulling finnoshea's fix (removing the -werror flag) into the main line...

@fcr
Copy link
Collaborator Author

fcr commented Apr 14, 2022

Just for the record, this is the new error message. It seems that as long as the -Werror flag is used, its a game of "Wack a Mole"
xcode 13.3.1 error2.txt

@dkeeney
Copy link

dkeeney commented Apr 14, 2022

The objective of the -Werror flag was to force us to fix all (or at least most) of the warnings. I admit that some of the warnings we are now seeing may not really have a 'fix'. But I would try to avoid turning off -Werror everywhere.

@ctrl-z-9000-times
Copy link
Collaborator

See PR #982

The compromise that I've implemented in that PR is to enable the -Werror flag for Debug mode builds, but not for Release mode builds.

@fcr
Copy link
Collaborator Author

fcr commented Apr 18, 2022

The compromise that I've implemented in that PR is to enable the -Werror flag for Debug mode builds, but not for Release mode builds.

That solves this issue.

@fcr fcr closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants