Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Possible Multi-scale Prediction Overwrite in Post-loop Assignment #91

Open
nya-a-cat opened this issue Feb 3, 2025 · 0 comments
Open

Comments

@nya-a-cat
Copy link

Hi Zhao,

This line appears to use overwrite assignment to reassign the return value of scale_process to the prediction variable. Prior to this, within the loop, the code was already using prediction += scale_process(...) to accumulate predictions from different scales.

I am wondering if this overwrite assignment after the loop is intentional? My understanding is that it might overwrite the previously accumulated multi-scale results, and the final prediction would only retain the prediction from the last scale. If so, I am unsure if this aligns with the intended behavior of multi-scale testing.

Best.

Originally posted by @nya-a-cat in 5e5a0ba

@nya-a-cat nya-a-cat changed the title To Zhao Fix Possible Multi-scale Prediction Overwrite in Post-loop Assignment Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant