Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No flag in the site #101

Open
KM-Kinter opened this issue Jan 16, 2024 · 5 comments
Open

No flag in the site #101

KM-Kinter opened this issue Jan 16, 2024 · 5 comments
Assignees

Comments

@KM-Kinter
Copy link
Contributor

On windows, the flag does not show up, while on macOS and mobile it works
image

@KM-Kinter KM-Kinter self-assigned this Jan 16, 2024
@DoomHammer
Copy link
Member

@reinhrst can you take a look when you have a moment?

@KGrzeg
Copy link
Member

KGrzeg commented Jan 17, 2024

We're using the following character for switcher:

And I can confirrm that I am seeing them as two letters on Windows.
Also I see exactly the same characters in the source code: https://github.com/hs3city/hs3.pl/blob/main/config.toml#L10 https://github.com/hs3city/hs3.pl/blob/main/config.toml#L39 So it is not a problem with hugo nor some code processing.

From what I have read, Windows 10/11 does not support flags emojis at all 😓

We can work around that with images, or use webfont to render correct characters for everyone. I think, the font approach is the best.
https://lepture.com/en/2022/windows-country-flags-emoji

@reinhrst
Copy link
Contributor

This is the

I don't think this is correct; it's a combination of two unicode code points (regional indicator G and regional indicator B). Actually my editor (neovim) also displays them this way:

image

However more to the point: OS manufacturers decide themselves how they want things to look, and Windows indeed doesn't display them as flags.... One could argue that GB still is a good hint that it's a language switch (but I guess EN would be better). We can easily replace them for EN and PL if we thing this is better (or indeed use images, but it would be a bit more work).

@KM-Kinter
Copy link
Contributor Author

So how we will do it?

Leave it like this time or I must change it to PL/GB (two letters only)?

@reinhrst
Copy link
Contributor

I don't think there is an advantage to making it two letters, since it already displays as two letters on Windows, right?

Best would be to add two images, and use those. Either that, or leave it as it is, I would say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants