Prerendering #10
Open
Prerendering #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneacik
reviewed
Apr 12, 2021
| const url = 'http://localhost:3000' | ||
|
|
||
| if (!url) { | ||
| throw "Please provide URL as a first argument"; |
There was a problem hiding this comment.
this url is now hardcoded, therefore this if is unused
oneacik
reviewed
Apr 12, 2021
| const browser = await puppeteer.launch(); | ||
| const page = await browser.newPage(); | ||
| await page.goto(url, {waitUntil: 'networkidle0'}); | ||
| await page.screenshot({path: 'screenshot.png'}); |
There was a problem hiding this comment.
what is this screenshot used for?
There was a problem hiding this comment.
Good question! I think it was used merely to test this beast. Not required anymore.
oneacik
reviewed
Apr 12, 2021
| with: | ||
| python-version: 3.8 | ||
|
|
||
| - name: Run Prerender |
There was a problem hiding this comment.
I think it should be ran on the branch the build was executed
oneacik
reviewed
Apr 12, 2021
| set -x | ||
| npm install | ||
| npm start & | ||
| ./node_modules/.bin/wait-on http://localhost:3000 |
There was a problem hiding this comment.
This file should be divided into build.sh and generate-static-page.sh.
Or smth.
There was a problem hiding this comment.
Or the entire app code could be rewritten but that's beyond my humble capabilities.
oneacik
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.