Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] [Under The Hood] De-Duplicate websocket implementations #1555

Open
schlimmchen opened this issue Jan 18, 2025 · 0 comments
Open

[Request] [Under The Hood] De-Duplicate websocket implementations #1555

schlimmchen opened this issue Jan 18, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@schlimmchen
Copy link
Member

Is your feature request related to a problem? Please describe.

There is a lot of code duplication between all of the WebApi_ws_* files.

Describe the solution you'd like

Don't touch the upstream implementation, but introduce a common base class for all those websocket handlers. A lot of code can go into that base class.

Describe alternatives you've considered

No response

Additional context

No response
@schlimmchen schlimmchen added the enhancement New feature or request label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schlimmchen