From 943e097705ecf1405b652915d5e5565d6396553e Mon Sep 17 00:00:00 2001 From: Bernhard Kirchen Date: Mon, 2 Dec 2024 21:14:35 +0100 Subject: [PATCH] Fix: webapp: DPL: config hint only for governed inverters the config hint "inverters must be configured to be send/receive command" shall only show if a *governed* inverter has one of the communication switches disabled. --- webapp/src/views/PowerLimiterAdminView.vue | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/webapp/src/views/PowerLimiterAdminView.vue b/webapp/src/views/PowerLimiterAdminView.vue index 9d4751a6d..1d404640e 100644 --- a/webapp/src/views/PowerLimiterAdminView.vue +++ b/webapp/src/views/PowerLimiterAdminView.vue @@ -534,7 +534,13 @@ export default defineComponent({ ) { continue; } - if (!(inv.poll_enable && inv.command_enable && inv.poll_enable_night && inv.command_enable_night)) { + const commEnabled = + inv.poll_enable && inv.command_enable && inv.poll_enable_night && inv.command_enable_night; + const governed = this.governedInverters.some( + (cfgInv: PowerLimiterInverterConfig) => cfgInv.serial === inv.serial + ); + + if (governed && !commEnabled) { hints.push({ severity: 'requirement', subject: 'InverterCommunication' }); break; }