Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Post Job Cleanup w/ Postgres #117

Closed
1 of 3 tasks
vinchg opened this issue Jan 30, 2025 · 4 comments · Fixed by #118
Closed
1 of 3 tasks

Infinite Post Job Cleanup w/ Postgres #117

vinchg opened this issue Jan 30, 2025 · 4 comments · Fixed by #118
Labels
bug Something isn't working question Further information is requested

Comments

@vinchg
Copy link

vinchg commented Jan 30, 2025

Description: My docker compose contains postgres, and during post job cleanup, outputs a ridiculous amount of logs and never ends. The documentation seems to describe this behavior as having enabled debug mode, but there is literally no reference on how/when this is done. Any advice would be appreciated. I also wouldn't mind having the option to just not call docker compose down at all.

Action version: 2.0.2 / 2.1.0

Platform:

  • Ubuntu
  • macOS
  • Windows

Repro steps:

    - name: Docker compose up
      if: steps.check-compose.outputs.exists == 'true'
      uses: hoverkraft-tech/[email protected]
      with:
        compose-file: docker-compose.yaml"
        up-flags: "--quiet-pull"
        down-flags: "--timeout 5"

And a docker compose with postgres.

@vinchg vinchg added the bug Something isn't working label Jan 30, 2025
Copy link
Contributor

Hi, thank for reporting an issue, we will check it out very soon

@neilime
Copy link
Collaborator

neilime commented Jan 30, 2025

Hi @vinchg ,

Here is the documentation to enable debug mode on github action: https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/troubleshooting-workflows/enabling-debug-logging

I suggest to re-run your failing job with debug mode enabled (https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs)

Ps: I've updated to documentation (765986d)

@neilime neilime added the question Further information is requested label Jan 30, 2025
@vinchg
Copy link
Author

vinchg commented Jan 30, 2025

Thanks for the response, I elected to try swapping actions to adambirds/[email protected] and w/ the same args it works w/o a hitch - no logs on post cleanup and docker compose down takes a second. There's likely a bug here that's forcing debug mode on w/o the user enabling it and perhaps something affecting the cleanup.

@vinchg vinchg closed this as completed Jan 30, 2025
@neilime neilime linked a pull request Jan 30, 2025 that will close this issue
@neilime
Copy link
Collaborator

neilime commented Jan 30, 2025

@vinchg thank you for your feedback, I've understood your issue.
We made a fix and publish a new release: https://github.com/hoverkraft-tech/compose-action/releases/tag/v2.2.0

Log output verbosity is reduced now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants