Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RandomEventsGame::learn ConcurrentModificationException when resetting lore #35

Open
hopperelec opened this issue Sep 24, 2023 · 2 comments
Open

RandomEventsGame::learn ConcurrentModificationException when resetting lore #35

hopperelec opened this issue Sep 24, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@hopperelec
Copy link
Owner

RandomEventsGame::learn iterates through itemsWithLore.get(seed) but also RandomEventsGame::resetLoreFor >RandomEventsGame::removeLoreFor which removes items from itemsWithLore
@hopperelec hopperelec added the bug Something isn't working label Sep 24, 2023
@hopperelec
Copy link
Owner Author

I think I'd like to fix this by giving RandomEventsGame::resetLoreFor custom functionality, because lots of code from removeLoreFrom and addLoreTo are redundant when used at the same time and lead to issues like this

@hopperelec
Copy link
Owner Author

Why is handling lore such a pain..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hopperelec