-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darkmode #11
Comments
I was waiting for this! If you have any experience on how to add a dark mode in a graceful way, please let me know! :) |
Maybe this could help ? |
Thank you for the pull request to address this issue. During my analysis I ran into the same problem, that a dark mode in Bootstrap 3 is only possible with two matching themes. I could not find any vanilla dark theme. The themes you proposed have some rendering issues with too small font sizes in progress bars and the footer white space is too small. As of now I would not implement this PR, because it would decrease the readability of the report. I suspect that there is no easy shortcut to achieve a clean dark mode in Bootstrap 3 other than using themes. Therefore I will look into theming and try to create a vanilla theme (should be easy) and a dark theme (only changed colors) for Bootstrap 3. I will leave #14 open, because a solution is in sight. Thank you again for your work! |
looks like we need to revise the code back to zero if we need to implement the dark mode. |
Requesting Darkmode for this nmap bootstrap :)
The text was updated successfully, but these errors were encountered: