Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkmode #11

Open
0xspade opened this issue May 17, 2020 · 4 comments · May be fixed by #14
Open

Darkmode #11

0xspade opened this issue May 17, 2020 · 4 comments · May be fixed by #14
Assignees
Labels
enhancement New feature or request

Comments

@0xspade
Copy link

0xspade commented May 17, 2020

Requesting Darkmode for this nmap bootstrap :)

@honze-net
Copy link
Owner

I was waiting for this! If you have any experience on how to add a dark mode in a graceful way, please let me know! :)

@honze-net honze-net self-assigned this May 18, 2020
@honze-net honze-net added the enhancement New feature or request label May 18, 2020
@3isenHeiM
Copy link
Contributor

Maybe this could help ?
I'm not a developer, but I've stumbled upon this and it might do the trick.

@3isenHeiM 3isenHeiM linked a pull request Dec 14, 2020 that will close this issue
@honze-net honze-net linked a pull request Dec 24, 2020 that will close this issue
@honze-net
Copy link
Owner

Thank you for the pull request to address this issue. During my analysis I ran into the same problem, that a dark mode in Bootstrap 3 is only possible with two matching themes. I could not find any vanilla dark theme. The themes you proposed have some rendering issues with too small font sizes in progress bars and the footer white space is too small. As of now I would not implement this PR, because it would decrease the readability of the report.

I suspect that there is no easy shortcut to achieve a clean dark mode in Bootstrap 3 other than using themes. Therefore I will look into theming and try to create a vanilla theme (should be easy) and a dark theme (only changed colors) for Bootstrap 3.

I will leave #14 open, because a solution is in sight. Thank you again for your work!

@honze-net honze-net removed a link to a pull request Dec 24, 2020
@honze-net honze-net linked a pull request Dec 24, 2020 that will close this issue
@0xspade
Copy link
Author

0xspade commented Feb 18, 2022

looks like we need to revise the code back to zero if we need to implement the dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants